New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packaging requirement for version 21.3.0 #640

Merged

whimboo merged 1 commit into mozilla:master from whimboo:packaging

Apr 5, 2023

Contributor

whimboo commented Apr 4, 2023

None of the tests use the packaging module but mozdownload code itself. So my patch on #636 was actually wrong and this PR fixes it.


          Fix packaging requirement for version 21.3.0.

3b82412

whimboo added this to the 1.28.0 milestone

juliandescottes approved these changes

View reviewed changes

juliandescottes left a comment

Thanks, this seems straightforward. No usage of packaging in tests, also verified that tests run fine on a fresh clone with those changes.

whimboo merged commit 812e1df into mozilla:master

6 checks passed

whimboo deleted the packaging branch

April 5, 2023 06:00

whimboo mentioned this pull request

Replace packaging.LegacyVersion use with mozilla_version. Fixes #635 #638

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment