Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quick-xml to 0.25 #880

Merged
merged 1 commit into from Sep 10, 2022
Merged

Conversation

trinity-1686a
Copy link
Contributor

quick-xml 0.23 and 0.24 were yanked following tafia/quick-xml#471. This break installation of grcov from crates.io directly (but not building from this repo thanks to Cargo.lock) with the following error:

$> cargo install grcov
    Updating crates.io index
  Installing grcov v0.8.11
error: failed to compile `grcov v0.8.11`, intermediate artifacts can be found at `/tmp/cargo-installo0bs24`

Caused by:
  failed to select a version for the requirement `quick-xml = "^0.23"`
  candidate versions found which didn't match: 0.25.0, 0.22.0, 0.21.0, ...
  location searched: crates.io index
  required by package `grcov v0.8.11`

This PR update quick-xml to 0.25 so it can build again with no Cargo.lock

Would it be possible to get a 0.8.12 after this get merged, so cargo install works again?

Copy link
Collaborator

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman calixteman merged commit e95db5f into mozilla:master Sep 10, 2022
@trinity-1686a trinity-1686a deleted the update-quick-xml branch September 10, 2022 17:13
@marco-c
Copy link
Collaborator

marco-c commented Sep 11, 2022

v0.8.12 released and published!

@trinity-1686a
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants