Skip to content

Commit

Permalink
Change dev port from 5000 to 5555 (#2044)
Browse files Browse the repository at this point in the history
  • Loading branch information
Iinh committed Dec 4, 2023
1 parent c10c6a8 commit 672fd78
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -40,7 +40,7 @@ npm run dev
```

If that worked, you should be able to see a local version of Glean at
http://localhost:5000
http://localhost:5555

You can speed up the "build data" step by appending the name of a set of
application(s) you want to build metadata for. This can speed up the process
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -14,7 +14,7 @@
"format:check": "prettier --plugin-search-dir=. --check .",
"lint": "eslint .",
"lint-glean": "cross-env VIRTUAL_ENV=venv glean glinter src/telemetry/metrics.yaml src/telemetry/pings.yaml",
"start": "sirv public",
"start": "sirv public --watch --port 5555",
"storybook": "storybook dev --static-dir ./public -p 6006",
"test": "npm-run-all format:check lint lint-glean test:jest test:playwright",
"test:jest": "jest tests src --no-cache",
Expand Down
2 changes: 1 addition & 1 deletion playwright.config.js
Expand Up @@ -2,7 +2,7 @@ const config = {
webServer: {
// run sirv in single-page application mode so non-root URLs (e.g. /apps/fenix/pings/metrics) work
command: "npm run start -- --single",
port: 5000,
port: 5555,
timeout: 120 * 1000,
reuseExistingServer: !process.env.CI,
},
Expand Down
10 changes: 5 additions & 5 deletions playwright/test.spec.js
@@ -1,12 +1,12 @@
const { test, expect } = require("@playwright/test");

test("first playwright test", async ({ page }) => {
await page.goto("http://localhost:5000");
await page.goto("http://localhost:5555");
await expect(page).toHaveTitle(/Glean Dictionary/);
});

test("metrics ping page", async ({ page }) => {
await page.goto("http://localhost:5000/apps/fenix/pings/metrics");
await page.goto("http://localhost:5555/apps/fenix/pings/metrics");
await expect(page).toHaveTitle("metrics | Firefox for Android");

// we expect a selector starting with our looker URL, directing to an explore
Expand All @@ -18,7 +18,7 @@ test("metrics ping page", async ({ page }) => {

test("activation id metric page", async ({ page }) => {
await page.goto(
"http://localhost:5000/apps/fenix/metrics/activation_activation_id"
"http://localhost:5555/apps/fenix/metrics/activation_activation_id"
);
await expect(page).toHaveTitle(
"activation.activation_id | Firefox for Android"
Expand All @@ -32,13 +32,13 @@ test("activation id metric page", async ({ page }) => {
});

test("org.mozilla.fenix app id page", async ({ page }) => {
await page.goto("http://localhost:5000/apps/fenix/app_ids/org_mozilla_fenix");
await page.goto("http://localhost:5555/apps/fenix/app_ids/org_mozilla_fenix");
await expect(page).toHaveTitle("org.mozilla.fenix | Firefox for Android");
});

test("activation table page", async ({ page }) => {
await page.goto(
"http://localhost:5000/apps/fenix/app_ids/org_mozilla_fenix/tables/activation"
"http://localhost:5555/apps/fenix/app_ids/org_mozilla_fenix/tables/activation"
);
await expect(page).toHaveTitle(
"org_mozilla_fenix.activation | org.mozilla.fenix | Firefox for Android"
Expand Down

0 comments on commit 672fd78

Please sign in to comment.