Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Shared Layer Cache: Does this work? #5941

Closed
wants to merge 1 commit into from
Closed

Conversation

jaredlockhart
Copy link
Collaborator

Testing

@jaredlockhart jaredlockhart marked this pull request as draft July 12, 2021 19:35
@jaredlockhart jaredlockhart force-pushed the docker-shared branch 5 times, most recently from f5d0729 to e077d0d Compare July 12, 2021 20:43
@jaredlockhart
Copy link
Collaborator Author

So it technically works insomuch as it pushes the layers to dockerhub and then locally when you build it'll discover and pull them in much more quickly than it would take to build them from scratch EXCEPT it does a tarball/export step every time that takes ~90s for our ~2gb dev image, regardless of whether the layers are already cached locally and haven't changed. So that pretty much negates the benefit of doing this. There's relevant tickets filed about this :

docker/buildx#626
docker/build-push-action#401

So we can revisit this in the future if that behaviour changes.

@jaredlockhart
Copy link
Collaborator Author

I did manage to get this working here #5944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant