Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Add eslint #75

Merged
merged 6 commits into from Apr 4, 2018
Merged

Add eslint #75

merged 6 commits into from Apr 4, 2018

Conversation

magopian
Copy link
Contributor

@magopian magopian commented Apr 4, 2018

Fixes #34

  • Add eslint to project (let's use the one bundled by default with CRA)
  • Add Airbnb eslint config
  • Add prettier-eslint, change package.json scripts accordingly
  • Ensure the CI process properly lints

@magopian
Copy link
Contributor Author

magopian commented Apr 4, 2018

We might not want airbnb eslint config after all:

@mythmon
Copy link
Contributor

mythmon commented Apr 4, 2018

I'd suggest eslint's recommended configuration combined with eslint-prettier. The recommended config handles most of correctness rules, and prettier handles formatting. It's not super opinionated like airbnb, but still has a decent set of rules. This is what I did in mozjexl

Copy link
Contributor

@rehandalal rehandalal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wheee! r+

@rehandalal rehandalal merged commit 4fa721e into mozilla:master Apr 4, 2018
magopian added a commit to magopian/delivery-console that referenced this pull request Apr 4, 2018
rehandalal added a commit that referenced this pull request Apr 4, 2018
Fixup following the merge of PR #75
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants