Add a way to generate a list of symbols for dynamic linkage #916
Conversation
TheElectronWill
changed the title
There was a problem hiding this comment.
Nice - I might need exactly something like this in a project of mine in the next few months.
in a format that the linker (ld) can understand.
Which linkers specifically support this option? Is the --dynamic-list option of the gold linker compatible with the format, or did you only test with ldd? Is there any documentation on the exact format?
TheElectronWill
force-pushed
the
symbols-files
branch
from
3bb7400
to
f4cd4a1
Compare
The manual doesn't clearly explain the format. Gnu linker's manual reads "The format of the dynamic list is the same as the version node without scope and node name. See VERSION", and that "version" thing is introduced here. I would expect at least GNU ld, lld and gold to work with that (I have only tested ld for the moment, but I'm confident that it works with lld too since it's been implemented with the same format in 2016). It would be weird for a linker to offer the same option but with a different format IMO. |
TheElectronWill
force-pushed
the
symbols-files
branch
from
f4cd4a1
to
6fc7d2b
Compare
|
rebased |
| @@ -131,6 +131,28 @@ impl Bindings { | |||
| fields | |||
| } | |||
|
|
|||
| /// Lists the exported symbols that can be dynamically linked, i.e. globals and functions. | |||
| pub fn dynamic_symbols_names(&self) -> Vec<String> { | |||
There was a problem hiding this comment.
Probably:
fn dynamic_symbols_names(&self) -> impl Iterator<Item = &str>
And just chain the two things:
self.functions.iter().map(|f| f.path().name())
.chain(self.globals.iter().map(|g| g.export_name()))
| std::fs::create_dir_all(dir).unwrap(); | ||
| } | ||
| let mut symfile = File::create(symfile_path).unwrap(); | ||
| write!(&mut symfile, "{{\n{};\n}};\n", symbols.join(";\n")).expect("Writing symbol file failed"); |
There was a problem hiding this comment.
I'd probably write this iteratively using the above function rather than storing all the file contents in memory, but it's probably not a huge deal.
This resolves #907 by adding the ability to generate the list of exportable symbols (i.e. functions and globals), in a format that the linker (ld) can understand. Like
depfile, this new feature is available both as a CLI option (--symfile) and as a method inBindings. Therefore, it's easy to use it in a build script.Most of the new files are tests on the output of the new option
--symfile.