Update dependencies and bump MSRV to v1.70 #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilio What do you think - would bumping the MSRV to 1.70 be acceptable now, given that it is half a year old? |
This also removes the dependency on the unmaintained crate atty. Closes mozilla#828
Disable default features (logging, async), since we don't need them right now.
jschwe
force-pushed
the
jschwender/clap-up2
branch
from
de2e584
to
dd88ef0
Compare
emilio
approved these changes
Feb 26, 2024
|
Thanks for picking this up, especially the upgrade from clap 3 to 4. Would be awesome to have a release with this :) |
Open
Indeed, this would be super appreciated! For those of us who try to resolve vulnerability alerts on all our GitHub repositories, we're unfortunately stuck until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.70 was released on 2023-06-01, so it is half a year old by now. It is also the minimum version I got the updated dependencies to compile on.
Based on #870.
Closes #880
Closes #899