New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve fully-qualified associated types #905

Open

orangeng wants to merge 1 commit into mozilla:master from orangeng:parse-assoc-types

orangeng commented Dec 7, 2023 •

edited

In the parsing stage, the functionality of the syn::Impl parsing is extended to keep track of associated type implementations in trait Impls.

This info is kept in a hash-map, where the key is a combination of (self type, trait name, associated type name) and the value is the concrete type itself.

In the library/transformation stage, this populated hashmap is then referenced to resolve associated types found.

Closes #106

mversic force-pushed the parse-assoc-types branch from c15a902 to cda3c70 Compare

December 7, 2023 08:24

mversic reviewed

View reviewed changes

src/bindgen/ir/generic_path.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/field.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/library.rs Outdated Show resolved Hide resolved

orangeng changed the title ~~Added functionality to resolve fully-qualified trait associated types in cbindgen~~ Added functionality to resolve fully-qualified trait associated types in cbindgen. Closes #106

orangeng changed the title ~~Added functionality to resolve fully-qualified trait associated types in cbindgen. Closes #106~~ Resolve fully-qualified associated types

orangeng force-pushed the parse-assoc-types branch from cda3c70 to 712ca52 Compare

December 7, 2023 09:19

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/generic_path.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/generic_path.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/generic_path.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/ty.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/ir/ty.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

mversic reviewed

View reviewed changes

src/bindgen/parser.rs Outdated Show resolved Hide resolved

orangeng force-pushed the parse-assoc-types branch 2 times, most recently from 2cd1735 to a76a4e8 Compare

December 11, 2023 07:27

mversic force-pushed the parse-assoc-types branch from a76a4e8 to beb281c Compare

February 15, 2024 18:04

Contributor

mversic commented Mar 9, 2024

@emilio can we move this to completion? it's a great feature?
@orangeng can you fix the lints?

mversic force-pushed the parse-assoc-types branch from beb281c to 3ff88a9 Compare

March 9, 2024 08:50

mversic force-pushed the parse-assoc-types branch 3 times, most recently from 85891a9 to fa24f93 Compare

April 23, 2024 11:46


          Resolve fully-qualified associated types

2895b55

mversic force-pushed the parse-assoc-types branch from fa24f93 to 2895b55 Compare

April 23, 2024 11:49

Contributor

mversic commented Apr 27, 2024

@emilio is there something blocking the merge of this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment