Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #868

Merged
merged 4 commits into from Aug 25, 2023
Merged

Fix CI #868

merged 4 commits into from Aug 25, 2023

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Aug 25, 2023 •
edited

Fix the following things that broke CI.

  • Commit 667de09 broke CI by adding rust-toolchain.toml, which changed the default rust version to nightly. Explicitly specify the rust version in CI to use the correct toolchain.
  • Revert upgrade to clap 4, since it causes the "Test package" test to fail.
  • Fix a new clippy warning

@jschwe
Fix CI
f0c39fb 
Commit 667de09
broke CI by adding rust-toolchain.toml, which changed
the default rust version to nightly.
Explicitly specify the rust version in CI to use the correct
toolchain.
@jschwe
Fix clippy warning
3f79cac 
Rust 1.72 added a new warning, which should have been ignored
by clippy, since clippy.toml is still st to 1.57.0
@jschwe
Revert "Upgrade clap 3 to clap 4"
378eb89 
This reverts commit b734008.
@jschwe jschwe mentioned this pull request Aug 25, 2023
Merged
@jschwe
Fix minimal Rust version in CI
24cdc76 
The minimum rust version was bumped, so we need
to install the appropriate version in CI.
@jschwe
Copy link
Contributor Author

jschwe commented Aug 25, 2023

@emilio This PR fixes CI failures introduced by the recent merges. In the case of clap, I propose reverting for now until the author has time to investigate why the tests are failing after upgrading clap.

@emilio
Copy link
Collaborator

emilio commented Aug 25, 2023

Yeah, I agree. I was fixing the failures locally, but this is better to get 0.25 out.

@emilio emilio merged commit dd9a550 into mozilla:master Aug 25, 2023
2 checks passed
@faern faern mentioned this pull request Aug 26, 2023
Closed
@faern faern mentioned this pull request Sep 8, 2023
Closed
@jschwe jschwe deleted the fix_ci branch February 24, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jschwe @emilio