Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Restore release action and add semver checks to CI deploy job #843

Merged
merged 3 commits into from Aug 25, 2023
Merged

CI: Restore release action and add semver checks to CI deploy job #843

merged 3 commits into from Aug 25, 2023

Conversation

jschwe
Copy link
Contributor

@jschwe jschwe commented Jun 5, 2023 •
edited

This MR restores the release action, which creates a github release upon tag.
We now use the github-cli to release the release instead of the third party action, which is not allowed by mozilla.

@jschwe
CI: Add semver checks to CI deploy job
a7060f1 
This will fail creating a new github release, if the semver
action fails.
This would have caught mozilla#841.
@jschwe
Copy link
Contributor Author

jschwe commented Jun 5, 2023 •
edited

For this to work, the following actions would need to be allowed by mozilla:
- obi1kenobi/cargo-semver-checks-action (could be worked around by manually installing and using cargo-semver-checks)
- softprops/action-gh-release (could also be manually done, but that would probably be more work)

Edit: resolved by switching to respective cli tools.

@jschwe jschwe changed the title CI: Add semver checks to CI deploy job CI: Restore release action and add semver checks to CI deploy job Jun 22, 2023
@jschwe
Copy link
Contributor Author

jschwe commented Jun 22, 2023 •
edited

@emilio This PR is not tested in my fork of cbindgen:

Currently, the restored release action only creates a "draft" release, so that we could verify first if everything actually works as expected on the main repo. On my fork it works fine, so we could also remove the --draft parameter.

Could you release v0.25 with this? I'd like to get a release with the depfile changes, and while we are at it we could verify if the release action works as expected.

Edit 1: Edited comment to reflect that the PR was tested on my fork of cbindgen.

@jschwe
CI: Replace forbidden actions with cli code
55747e1 
the semver checks action and the release action are not
in the allow-list so replace them with their respective
cli counterparts.
These changes can only be tested by someone with permissions,
so the release part only releases a draft release for now.
@jschwe
Copy link
Contributor Author

jschwe commented Jul 17, 2023

@emilio Would you have time to review this and/or release v0.25.0?

1 similar comment
@jschwe
Copy link
Contributor Author

jschwe commented Aug 25, 2023

@emilio Would you have time to review this and/or release v0.25.0?

@emilio emilio merged commit 80526e7 into mozilla:master Aug 25, 2023
2 checks passed
@jschwe jschwe deleted the semver branch August 25, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jschwe @emilio