Avoid 'duplicate package' warnings when depending on cbindgen via git #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to fail still, but other than that it looks fine |
irh
force-pushed
the
avoid-duplicate-package-warnings
branch
from
2241927
to
29bfe80
Compare
When specifying `cbindgen` as a dependency via git, several 'skipping duplicate package' warnings pop up regarding some of the test crates. The warning seems to be spurious given that the test packages aren't needed when depending on `cbindgen` (see rust-lang/cargo#10752), but while a fix is being considered for Cargo, this commit disambiguates the duplicated package names by referring to their relative paths.
irh
force-pushed
the
avoid-duplicate-package-warnings
branch
from
29bfe80
to
cbb725f
Compare
|
Thanks for taking a look, I found the problem and the checks are now green. |
emilio
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying
cbindgenas a dependency via git, several 'skipping duplicate package' warnings pop up regarding some of the test crates.The warning seems to be spurious given that the test packages aren't needed when depending on
cbindgen(see rust-lang/cargo#10752), but while a fix is being considered for Cargo, this PR disambiguates the duplicated package names by referring to their relative paths.