Update syn related dependencies to 1.0 #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Aug 15, 2019
|
@dtolnay is serde-rs/serde#1591 expected to land soon-ish? If so we may as well wait for that. |
|
Done |
Eijebong
force-pushed
the
syn-1.0
branch
2 times, most recently
from
4d9a486
to
2875929
Compare
|
Travis is always complaining 😄 |
|
There, should be fixed |
emilio
requested changes
Aug 18, 2019
| syn::Item::TraitAlias(ref item) => (|$i: &syn::ItemTraitAlias| $a)(item), | ||
| syn::Item::Verbatim(_) => (|| $b)(), | ||
| _ => panic!("Unhandled syn::Item: {:?}", $s), |
There was a problem hiding this comment.
I'd prefer to keep handling the others.
There was a problem hiding this comment.
Unfortunately https://docs.rs/syn/1.0.3/src/syn/item.rs.html#79
emilio
approved these changes
Aug 18, 2019
|
Oh, also, mind not doing the Cargo.toml version bump? I hope to merge #377 soonish, though I may as well do two releases so no big deal I guess. |
|
Sure, I'll remove it |
Eijebong
changed the title
emilio
added a commit
that referenced
this pull request
Aug 25, 2019
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 6, 2019
Changelog:
## 0.9.1
* Various improvements to comment output. mozilla/cbindgen#370 / mozilla/cbindgen#375.
* Fixed expand when ran from build.rs. mozilla/cbindgen#371
* More debugging output for expansion. mozilla/cbindgen#383
* New option to add a default private constructor in C++ tagged enums. mozilla/cbindgen#377
* Syn and related dependencies updated to 1.0. mozilla/cbindgen#379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.