Support scheme-less urls if "https" is allowed (#662) #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we allowed scheme-less urls if "http" was allowed. This expands that to also support "https".
willkg
commented
Jun 2, 2022
| '<a href="/path">valid</a>', | ||
| {"protocols": ["https"]}, | ||
| '<a href="/path">valid</a>', | ||
| ), |
There was a problem hiding this comment.
I added this one, but not the others figuring if this one works, they all work.
willkg
commented
Jun 2, 2022
| if "http" in allowed_protocols: | ||
| # If there's no protocol/scheme specified, then assume it's "http" or | ||
| # "https" and see if that's allowed | ||
| if "http" in allowed_protocols or "https" in allowed_protocols: |
There was a problem hiding this comment.
This is the minimal change to fix the bug. I do think the things we talked about are interesting as well, but I think I want to push them off so as to get 5.0.1 out the door.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we allowed scheme-less urls if "http" was allowed. This
expands that to also support "https".
Fixes #662