New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly urlencode email address parts #659
Conversation
@larseggert Can you fix up the broken tests? Thanks! If you don't have time for that, I can get to it this month. I think it's mostly fixing "@" -> "%40" kinds of things. |
@willkg could you kick the CI tests? For some reason, running the tests locally via |
You should be able to run tests locally. Can you elaborate on what doesn't work when you run tox? |
When I run |
If you create a virtual environment and install everything with:
that should install Bleach into the virtual environment in an editable mode which will reflect changes you're making in the Does that help? |
How do I do that? |
Python comes with a virtual environment system. It's a convenient way to install things in a sandbox that doesn't affect your system-wide Python setup. This is very convenient for development where the things you're working on might be in flux or have bugs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
Fixes #658