Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo of #603 against main / 4.x #642

Closed
wants to merge 4 commits into from
Closed

Redo of #603 against main / 4.x #642

wants to merge 4 commits into from

Conversation

jvanasco
Copy link
Contributor

@jvanasco jvanasco commented Feb 11, 2022 •
edited

I manually reapplied the patch from the #603 (bleach 3.x) to address #369, as the merge against 4.x did not want to happen cleanly.

@jvanasco jvanasco mentioned this pull request Feb 11, 2022
Closed
@dfdan dfdan mentioned this pull request Feb 16, 2022
Closed
willkg
willkg requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good except the commit messages aren't very helpful.

Can you squash the commits into a single commit that has a helpful commit message?

@willkg willkg added this to the v5.0.0 milestone Feb 17, 2022
@willkg willkg mentioned this pull request Apr 4, 2022
Merged
@willkg
Copy link
Member

willkg commented Apr 4, 2022

I grabbed the commits in this PR and redid them in PR #651.

@willkg willkg closed this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkg willkg willkg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jvanasco @willkg