Fix semantic whitespace (Issue #369) #461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space) * adjusting if-condition to have a lower-cpu check for `_token_data` first, before checking for it's type via `isinstance`
2. tracking state of the last stripped tag 3. some small optimizations on __init__
* dropped tracking of the last tag; not worth it
|
Closing in favor of a new PR against the current master. |
jvanasco
added a commit
to jvanasco/bleach
that referenced
this pull request
Jul 23, 2021
block elements are tracked and a newline is inserted when they are stripped. new tests are included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing with many edge-cases, I decided two things:
minimizing whitespace is far too difficult due to the design of this package. the 'stripping' of tags occurs in a place that can not look backwards enough and can not access the 'content' without a large redesign
the whitespace should be a newline, not a space (as suggested in [Accessibility bug] Semantic whitespace implied by block elements isn't retained properly #369). this is because content becomes too confusing to understand with a "space" (such as list elements)