fix for issue #369 #460
Closed
fix for issue #369 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space) * adjusting if-condition to have a lower-cpu check for `_token_data` first, before checking for it's type via `isinstance`
|
closing this because I found some edge cases on a larger test suite. will fix and refile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at #369. I am not particularly happy with it, but I could not figure out a better way to handle this. The start/end tokens are already collapsed by the time we get to any of the sections I would feel more comfortable handling this in. More tests are needed, but i'll defer that to others.
Changes:
HTML_TAGS__BLOCK_LEVELcontains the list of block level elementsInputStreamWithMemorynow tracks the last emitted token, because...InputStreamWithMemoryemits a SPACE instead of no-space if the following conditions are met: