Correctly urlencode email address parts

[larseggert]

Fixes #658

[willkg]

@larseggert Can you fix up the broken tests? Thanks!

If you don't have time for that, I can get to it this month. I think it's mostly fixing "@" -> "%40" kinds of things.

[larseggert]

@willkg could you kick the CI tests? For some reason, running the tests locally via tox doesn't work.

[willkg]

You should be able to run tests locally. Can you elaborate on what doesn't work when you run tox?

[larseggert]

When I run tox locally, the change I make to handle_email_addresses don't seem to be picked up. Ditto when I just run pytest.

[willkg]

If you create a virtual environment and install everything with:

pip install -e '.[dev,css]'

that should install Bleach into the virtual environment in an editable mode which will reflect changes you're making in the src/ directory.

Does that help?

[larseggert]

If you create a virtual environment

How do I do that?

[willkg]

Python comes with a virtual environment system. It's a convenient way to install things in a sandbox that doesn't affect your system-wide Python setup. This is very convenient for development where the things you're working on might be in flux or have bugs.

• https://docs.python.org/3/library/venv.html
• https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/#creating-a-virtual-environment
• https://bleach.readthedocs.io/en/latest/dev.html#install-for-development

[willkg]

Thank you for doing this!