Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency underscore to v1.12.1 #16742

Merged
merged 1 commit into from Mar 22, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 15, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
underscore (source) 1.12.0 -> 1.12.1 age adoption passing confidence

Release Notes

jashkenas/underscore

v1.12.1

Compare Source


Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@willdurand
Copy link
Member

mmm let's not merge this update right now, I cannot see it here: https://github.com/jashkenas/underscore/releases

@eviljeff
Copy link
Member

jashkenas/underscore#2915 I guess

(do we even use underscore in addons-server still?)

@eviljeff
Copy link
Member

(do we even use underscore in addons-server still?)

apparently so 馃樋 - 89 matches for _. in static/js, excluding bundled files. (Probably some dead code and/or false positives in there). I'm sure there are modern js equivalent functionality if we want to spend the time rewriting though.

@willdurand
Copy link
Member

apparently so 馃樋 - 89 matches for _. in static/js, excluding bundled files. (Probably some dead code and/or false positives in there). I'm sure there are modern js equivalent functionality if we want to spend the time rewriting though.

/o\

jashkenas/underscore#2915 I guess

(do we even use underscore in addons-server still?)

I don't know really, I see some 1.13 tags but not that specific version :/

@renovate renovate bot force-pushed the renovate/underscore-1.x branch from 52c31d5 to aefbd58 Compare March 22, 2021 13:05
@willdurand willdurand merged commit 6aeb7dd into master Mar 22, 2021
@willdurand willdurand deleted the renovate/underscore-1.x branch March 22, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants