Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll idna back to 2.10 because requests #16253

Merged
merged 3 commits into from Jan 11, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 5, 2021

Bumps idna from 3.0 to 3.1.

Changelog

Sourced from idna's changelog.

3.1 (2021-01-04) ++++++++++++++++

  • Ensure license is included in package (Thanks, Julien Schueller)
  • No longer mark wheel has universal (Thanks, Matthieu Darbois)
  • Test on PowerPC using Travis CI
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Bumps [idna](https://github.com/kjd/idna) from 3.0 to 3.1.
- [Release notes](https://github.com/kjd/idna/releases)
- [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst)
- [Commits](kjd/idna@v3.0...v3.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 5, 2021
@eviljeff
Copy link
Member

eviljeff commented Jan 7, 2021

we might have to roll back to pre 3.0 to fix the requests incompatibility so not merging this but keeping it open to remind us (me). The fix there is in psf/requests#5711 but has been proceeding pretty slowly.

@eviljeff eviljeff changed the title Bump idna from 3.0 to 3.1 in /requirements Roll idna back to 2.10 Jan 11, 2021
@eviljeff eviljeff changed the title Roll idna back to 2.10 Roll idna back to 2.10 because requests Jan 11, 2021
@eviljeff eviljeff merged commit bc89f6f into master Jan 11, 2021
@eviljeff eviljeff deleted the dependabot/pip/requirements/idna-3.1 branch January 11, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant