Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump single file size limit from 4MB to 5MB #4749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wrbl606
Copy link

@wrbl606 wrbl606 commented Mar 12, 2023

Fixes #4748

Bumped single file size limit from 4MB to 5MB to use WASM modules more easily. The change is covered by already existing tests.

Once you have met the above requirements please replace this section with a Fixes #ISSUENUM linking to the issue fixed by this PR along with an explanation of the changes. Thanks for your contribution!

Linter output after the fix was applied. Notice no errors, just warnings:
Validation Summary:

errors          0              
notices         0              
warnings        11             

WARNINGS:

Code                    Message       Description              File          Line   Column
DANGEROUS_EVAL          The           Evaluation of strings    content/de…   2      7585  
                        Function      as code can lead to      ps/tessera…                
                        constructor   security                 ct@4.0.2.m…                
                        is eval.      vulnerabilities and      in.js                      
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
DANGEROUS_EVAL          eval can be   Evaluation of strings    content/de…   2      51521 
                        harmful.      as code can lead to      ps/worker@…                
                                      security                 4.0.2.min.…                
                                      vulnerabilities and      js                         
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
DANGEROUS_EVAL          The           Evaluation of strings    content/de…   2      65398 
                        Function      as code can lead to      ps/worker@…                
                        constructor   security                 4.0.2.min.…                
                        is eval.      vulnerabilities and      js                         
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
UNSAFE_VAR_ASSIGNMENT   Error in      Due to both security     content/de…   2      73068 
                        no-unsanit…   and performance          ps/worker@…                
                        ized:         concerns, this may not   4.0.2.min.…                
                        Unexpected    be set using dynamic     js                         
                        callable.     values which have not                               
                        Please        been adequately                                     
                        report a      sanitized. This can                                 
                        minimal       lead to security                                    
                        code          issues or fairly                                    
                        snippet to    serious performance                                 
                        the           degradation.                                        
                        developers                                                        
                        at                                                                
                        https://gi…                                                       
                        thub.com/m…                                                       
                        ozilla/esl…                                                       
                        int-plugin…                                                       
                        -no-unsani…                                                       
                        tized/issu…                                                       
                        es/new?tit…                                                       
                        le=unexpec…                                                       
                        ted%20Func…                                                       
                        tionExpres…                                                       
                        sion%20in%…                                                       
                        20normaliz…                                                       
                        eMethodCall                                                       
UNSAFE_VAR_ASSIGNMENT   Error in      Due to both security     content/de…   2      76723 
                        no-unsanit…   and performance          ps/worker@…                
                        ized:         concerns, this may not   4.0.2.min.…                
                        Unexpected    be set using dynamic     js                         
                        callable.     values which have not                               
                        Please        been adequately                                     
                        report a      sanitized. This can                                 
                        minimal       lead to security                                    
                        code          issues or fairly                                    
                        snippet to    serious performance                                 
                        the           degradation.                                        
                        developers                                                        
                        at                                                                
                        https://gi…                                                       
                        thub.com/m…                                                       
                        ozilla/esl…                                                       
                        int-plugin…                                                       
                        -no-unsani…                                                       
                        tized/issu…                                                       
                        es/new?tit…                                                       
                        le=unexpec…                                                       
                        ted%20Func…                                                       
                        tionExpres…                                                       
                        sion%20in%…                                                       
                        20normaliz…                                                       
                        eMethodCall                                                       
DANGEROUS_EVAL          The           Evaluation of strings    content/de…   2      138010
                        Function      as code can lead to      ps/worker@…                
                        constructor   security                 4.0.2.min.…                
                        is eval.      vulnerabilities and      js                         
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
DANGEROUS_EVAL          eval can be   Evaluation of strings    content/de…   2      51521 
                        harmful.      as code can lead to      ps/worker.…                
                                      security                 min.js                     
                                      vulnerabilities and                                 
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
DANGEROUS_EVAL          The           Evaluation of strings    content/de…   2      65398 
                        Function      as code can lead to      ps/worker.…                
                        constructor   security                 min.js                     
                        is eval.      vulnerabilities and                                 
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      
UNSAFE_VAR_ASSIGNMENT   Error in      Due to both security     content/de…   2      73068 
                        no-unsanit…   and performance          ps/worker.…                
                        ized:         concerns, this may not   min.js                     
                        Unexpected    be set using dynamic                                
                        callable.     values which have not                               
                        Please        been adequately                                     
                        report a      sanitized. This can                                 
                        minimal       lead to security                                    
                        code          issues or fairly                                    
                        snippet to    serious performance                                 
                        the           degradation.                                        
                        developers                                                        
                        at                                                                
                        https://gi…                                                       
                        thub.com/m…                                                       
                        ozilla/esl…                                                       
                        int-plugin…                                                       
                        -no-unsani…                                                       
                        tized/issu…                                                       
                        es/new?tit…                                                       
                        le=unexpec…                                                       
                        ted%20Func…                                                       
                        tionExpres…                                                       
                        sion%20in%…                                                       
                        20normaliz…                                                       
                        eMethodCall                                                       
UNSAFE_VAR_ASSIGNMENT   Error in      Due to both security     content/de…   2      76723 
                        no-unsanit…   and performance          ps/worker.…                
                        ized:         concerns, this may not   min.js                     
                        Unexpected    be set using dynamic                                
                        callable.     values which have not                               
                        Please        been adequately                                     
                        report a      sanitized. This can                                 
                        minimal       lead to security                                    
                        code          issues or fairly                                    
                        snippet to    serious performance                                 
                        the           degradation.                                        
                        developers                                                        
                        at                                                                
                        https://gi…                                                       
                        thub.com/m…                                                       
                        ozilla/esl…                                                       
                        int-plugin…                                                       
                        -no-unsani…                                                       
                        tized/issu…                                                       
                        es/new?tit…                                                       
                        le=unexpec…                                                       
                        ted%20Func…                                                       
                        tionExpres…                                                       
                        sion%20in%…                                                       
                        20normaliz…                                                       
                        eMethodCall                                                       
DANGEROUS_EVAL          The           Evaluation of strings    content/de…   2      138010
                        Function      as code can lead to      ps/worker.…                
                        constructor   security                 min.js                     
                        is eval.      vulnerabilities and                                 
                                      performance issues,                                 
                                      even in the most                                    
                                      innocuous of                                        
                                      circumstances. Please                               
                                      avoid using `eval` and                              
                                      the `Function`                                      
                                      constructor when at                                 
                                      all possible.'                                      

┆Issue is synchronized with this Jira Task

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (637f687) 98.77% compared to head (4c379a9) 98.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4749   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          54       54           
  Lines        2868     2868           
  Branches      865      865           
=======================================
  Hits         2833     2833           
  Misses         35       35           
Impacted Files Coverage Δ
src/const.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tesseract's WASM file too big to process
1 participant