Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump serialize-javascript from 1.9.1 to 2.1.1 #9025

Merged
merged 2 commits into from Dec 10, 2019
Merged

Bump serialize-javascript from 1.9.1 to 2.1.1 #9025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c1e3dc
Bump serialize-javascript from 1.9.1 to 2.1.1
dependabot[bot] Dec 9, 2019
5b10867
mark serialized content as json
willdurand Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -277,7 +277,7 @@
"redux-saga": "0.16.2",
"regenerator-runtime": "0.13.3",
"response-time": "2.3.2",
"serialize-javascript": "1.9.1",
"serialize-javascript": "2.1.1",
"touch": "3.1.0",
"ua-parser-js": "0.7.20",
"universal-cookie-express": "4.0.1",
Expand Down
4 changes: 3 additions & 1 deletion src/amo/components/AddonHead/index.js
View file
Open in desktop
Expand Up @@ -160,7 +160,9 @@ export class AddonHeadBase extends React.Component<InternalProps> {
<title>{this.getPageTitle()}</title>

<script type="application/ld+json">
{serialize(_getAddonJsonLinkedData({ addon, currentVersion }))}
{serialize(_getAddonJsonLinkedData({ addon, currentVersion }), {
isJSON: true,
})}
</script>
</Helmet>

Expand Down
4 changes: 3 additions & 1 deletion src/core/components/ServerHtml/index.js
View file
Open in desktop
Expand Up @@ -228,7 +228,9 @@ export default class ServerHtml extends Component {
<div id="react-view" dangerouslySetInnerHTML={{ __html: content }} />

<script
dangerouslySetInnerHTML={{ __html: serialize(appState) }}
dangerouslySetInnerHTML={{
__html: serialize(appState, { isJSON: true }),
}}
type="application/json"
id="redux-store-state"
/>
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -13408,16 +13408,16 @@ send@^0.16.1:
range-parser "~1.2.0"
statuses "~1.4.0"

serialize-javascript@1.9.1, serialize-javascript@^1.7.0:
serialize-javascript@2.1.1, serialize-javascript@^2.1.0:
version "2.1.1"
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-2.1.1.tgz#952907a04a3e3a75af7f73d92d15e233862048b2"
integrity sha512-MPLPRpD4FNqWq9tTIjYG5LesFouDhdyH0EPY3gVK4DRD5+g4aDqdNSzLIwceulo3Yj+PL1bPh6laE5+H6LTcrQ==

serialize-javascript@^1.7.0:
version "1.9.1"
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-1.9.1.tgz#cfc200aef77b600c47da9bb8149c943e798c2fdb"
integrity sha512-0Vb/54WJ6k5v8sSWN09S0ora+Hnr+cX40r9F170nT+mSkaxltoE/7R3OrIdBSUv1OoiobH1QoWQbCnAO+e8J1A==

serialize-javascript@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-2.1.0.tgz#9310276819efd0eb128258bb341957f6eb2fc570"
integrity sha512-a/mxFfU00QT88umAJQsNWOnUKckhNCqOl028N48e7wFmo2/EHpTo9Wso+iJJCMrQnmFvcjto5RJdAHEvVhcyUQ==

serve-favicon@^2.5.0:
version "2.5.0"
resolved "https://registry.yarnpkg.com/serve-favicon/-/serve-favicon-2.5.0.tgz#935d240cdfe0f5805307fdfe967d88942a2cbcf0"
Expand Down