Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp: test action #12800

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tmp: test action #12800

wants to merge 1 commit into from

Conversation

KevinMind
Copy link
Contributor

@KevinMind KevinMind commented Jan 19, 2024

Relates to: mozilla/addons#5872

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdc17e7) 98.28% compared to head (e07c491) 98.28%.

❗ Current head e07c491 differs from pull request most recent head 92daf39. Consider uploading reports for the commit 92daf39 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   mozilla/addons-server#12800   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         268      268           
  Lines       10519    10519           
  Branches     3187     3187           
=======================================
  Hits        10339    10339           
  Misses        167      167           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KevinMind KevinMind force-pushed the localization branch 21 times, most recently from f3a1b22 to 294556f Compare January 19, 2024 19:04
@KevinMind
Copy link
Contributor Author

Generated this PR: #12801

@KevinMind KevinMind force-pushed the localization branch 3 times, most recently from fc4e29a to 7644112 Compare January 19, 2024 19:53
@KevinMind
Copy link
Contributor Author

I've merged all of the scripts into a single zx executable. It extracts and merges locales for the current code base. It is pretty fast 2x the previous set of scripts (<15seconds locally and in CI)

Local Options

  1. Run the locale.mjs script as a pre-commit hook
  2. Run the babel plugin directly in our dev and prod builds

CI options

  1. Run on every PR, failing if locales are not built
  2. Run on pull requests, pre merge (may need queue to do that I'm not sure)
  3. Run on master commits, post merge but pre tag
    a. we can commit directly on master
    b. we could open a PR with the generated locale changes.

All options would work, it's more about the kind of experience we want to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant