Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to driver and parser crates. #402

Merged
merged 2 commits into from Mar 19, 2020

Conversation

nbp
Copy link
Collaborator

@nbp nbp commented Mar 18, 2020

  • Add jsparagus-structured crate to store a macro which is used for logging
    structured output in a JSON like output.
  • Add env_logger dependency to enable/disable logging using RUST_LOG environment
    variable.

(Fix #398)

Note, there is currently a bug in the log crate which causes the trace! macro to leave some code around in the generated binary when compiled in non-release builds. However, this vanishes when compiled in release mode. (rust-lang/log#386)

* Add jsparagus-structured crate to store a macro which is used for logging
  structured output in a JSON like output.
* Add env_logger dependency to enable/disable logging using RUST_LOG environment
  variable.
@nbp nbp requested a review from arai-a March 18, 2020 13:57
@nbp nbp self-assigned this Mar 18, 2020
@nbp nbp merged commit 8ee9332 into mozilla-spidermonkey:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add logging to the parser.
2 participants