Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug 1877534: use --attach instead of --no-attach #2890

Merged
merged 4 commits into from Feb 1, 2024
Merged

bug 1877534: use --attach instead of --no-attach #2890

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d31bf7c
bug 1877534: use --attach-dependencies=false instead of --no-attach
relud Feb 1, 2024
7c17de8
Apply suggestions from code review
relud Feb 1, 2024
5f39b30
Apply suggestions from code review
relud Feb 1, 2024
1e9905f
Update Makefile
relud Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 5 additions & 9 deletions Makefile
View file
Open in desktop
Expand Up @@ -51,16 +51,12 @@ setup: .env ## | Initialize services.

.PHONY: run
run: .env .docker-build ## | Run the web app and services.
# NOTE(willkg): We tag all the backing services with --no-attach here to
# prevent them from spamming stdout
# NOTE(willkg): We tag all the services with --attach here to
# prevent dependencies from spamming stdout
${DC} up \
relud marked this conversation as resolved.
Show resolved Hide resolved
--no-attach db \
--no-attach statsd \
--no-attach gcs-emulator \
--no-attach redis-cache \
--no-attach localstack \
--no-attach oidcprovider \
--no-attach statsd \
--attach web \
--attach frontend \
--attach fakesentry \
web frontend fakesentry

.PHONY: devcontainerbuild
Expand Down