Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin Rust 1.60.0 #1326

Merged
merged 2 commits into from
Jun 3, 2022
Merged

chore: pin Rust 1.60.0 #1326

merged 2 commits into from
Jun 3, 2022

Conversation

ethowitz
Copy link
Contributor

@ethowitz ethowitz commented Jun 2, 2022

Description

Rust 1.61.0 uses substantially more memory than 1.60.0 in our CI builds, preventing them from completing (and preventing us from merging anything new). This PR pins Rust 1.60.0 until the issue is resolved upstream.

Upstream issue: rust-lang/rust#97549

@ethowitz ethowitz requested a review from a team June 2, 2022 19:13
@ethowitz ethowitz changed the title Use rust 1.60.0 chore: pin Rust 1.60.0 Jun 2, 2022
@@ -163,7 +163,7 @@ commands:
jobs:
checks:
docker:
- image: circleci/rust:latest
- image: cimg/rust:1.60.0
Copy link
Contributor Author

@ethowitz ethowitz Jun 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cimg here upgrades us to using CircleCI's new build images (circleci uses the legacy build images). More info here: https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034

@ethowitz ethowitz merged commit fdc97bc into master Jun 3, 2022
@ethowitz ethowitz deleted the use-rust-1.60.0 branch June 3, 2022 16:30
@jrconlin
Copy link
Member

jrconlin commented Jun 3, 2022

Heh, I was experimenting to see if there was a way we could convert the rust version to a Variable, because we pin to it for a bunch of different stuff (circleci, Dockerfile, etc.) We might be able to use an environment variable for it, but everything seemed complicated and prone to failure.

@taddes
Copy link
Contributor

taddes commented Jun 3, 2022

@jrconlin Where in such a large collection of crates or in such a project project would env vars typically sit? At the root, or say in the build directory? Is it a concern that said variable could be missed and result in regressions that are hard to find or fix? It does sound like a good idea though

@jrconlin
Copy link
Member

jrconlin commented Jun 3, 2022

Yeah, that's the biggest problem. Technically, the circleci config file should be the one that's at the top level since it fires off all the other containers, but it's not super easy to deal with. It might be possible to store them as environment variables, but then you'd have to go into the circleci admin panel to update the values, but that's a pain and prone to forgetting. There might be other methods as well, but they're equally complex and fragile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants