Reorg #135
Reorg #135
Conversation
catlee
force-pushed
the
reorg
branch
2 times, most recently
from
a937da9
to
8779860
Compare
Remove black, flake8, pip-compile-multi from test dependencies, and add to the 'check' environment.
MANIFEST.in
Outdated
| recursive-include signingscript/data * | ||
|
|
||
| recursive-include signingscript/vendored * | ||
| recursive-include src/signingscript |
There was a problem hiding this comment.
If you run python setup.py sdist and then tar tzvf dist/signingscript-12.1.0.tar.gz, you'll note that we lose data/ and vendored/ from the source tarball. We need the trailing * here.
| arrow==0.14.7 \ | ||
| --hash=sha256:4bfacea734ead51495dc47df00421ecfd4ca1f2c0fbe58b9a26eaeddedc31caf \ | ||
| --hash=sha256:67f8be7c0cf420424bc62d8d7dc40b44e4bb2f7b515f9cc2954fb36e35797656 | ||
| arrow==0.15.0 \ |
There was a problem hiding this comment.
Arrow 0.15.0 may be broken. We can likely leave it and fix in scriptworker.
There was a problem hiding this comment.
ok, I can revert this.
There was a problem hiding this comment.
It looks like we're not affected by it, so feel free to leave it.
| flake8 | ||
| flake8_docstrings | ||
| black | ||
| pydocstyle~=3.0 |
There was a problem hiding this comment.
Are these changes intentional? (Looks like these have been moved into tox.ini. Sure, though we lose the ability to update pins)
There was a problem hiding this comment.
well, we don't really need them to run the tests...but you're right, we lose pinning by putting them inside tox.
No description provided.