Skip to content

Commit

Permalink
Bug 1800611 - part 3: Use Mobile version numbers for Android-Components
Browse files Browse the repository at this point in the history
  • Loading branch information
JohanLorenzo committed Nov 28, 2022
1 parent 5c68958 commit ed52d75
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions api/src/shipit_api/admin/release.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import requests
from mozilla_version.fenix import FenixVersion # TODO replace with MobileVersion
from mozilla_version.gecko import DeveditionVersion, FennecVersion, FirefoxVersion, ThunderbirdVersion
from mozilla_version.maven import MavenVersion
from mozilla_version.mobile import MobileVersion

from shipit_api.common.config import SUPPORTED_FLAVORS
Expand All @@ -17,7 +16,7 @@
logger = logging.getLogger(__name__)

_VERSION_CLASS_PER_PRODUCT = {
Product.ANDROID_COMPONENTS: MavenVersion,
Product.ANDROID_COMPONENTS: MobileVersion,
Product.DEVEDITION: DeveditionVersion,
Product.PINEBUILD: FirefoxVersion,
Product.FENIX: FenixVersion,
Expand Down
3 changes: 1 addition & 2 deletions api/src/shipit_api/public/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from flask import abort, current_app
from mozilla_version.fenix import FenixVersion
from mozilla_version.gecko import DeveditionVersion, FennecVersion, FirefoxVersion, ThunderbirdVersion
from mozilla_version.maven import MavenVersion
from mozilla_version.mobile import MobileVersion
from werkzeug.exceptions import BadRequest

Expand All @@ -19,7 +18,7 @@
logger = logging.getLogger(__name__)

VERSION_CLASSES = {
Product.ANDROID_COMPONENTS.value: MavenVersion,
Product.ANDROID_COMPONENTS.value: MobileVersion,
Product.DEVEDITION.value: DeveditionVersion,
# XXX revisit when we know how pinebuild will be versioned
Product.PINEBUILD.value: FirefoxVersion,
Expand Down

0 comments on commit ed52d75

Please sign in to comment.