Fix new linter errors

mozilla-mobile · Nov 2, 2022 · abef20d · abef20d
1 parent 62bb45a
commit abef20d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/app/src/main/java/org/mozilla/reference/browser/addons/InstalledAddonDetailsActivity.kt b/app/src/main/java/org/mozilla/reference/browser/addons/InstalledAddonDetailsActivity.kt
@@ -7,7 +7,6 @@ package org.mozilla.reference.browser.addons
 import android.content.Intent
 import android.os.Bundle
 import android.view.View
-import android.widget.TextView
 import android.widget.Toast
 import androidx.appcompat.app.AppCompatActivity
 import androidx.appcompat.widget.SwitchCompat
@@ -78,11 +77,6 @@ class InstalledAddonDetailsActivity : AppCompatActivity() {
         bindRemoveButton(addon)
     }
 
-    private fun bindVersion(addon: Addon) {
-        val versionView = findViewById<TextView>(R.id.version_text)
-        versionView.text = addon.version
-    }
-
     private fun bindEnableSwitch(addon: Addon) {
         val switch = findViewById<SwitchCompat>(R.id.enable_switch)
         switch.setState(addon.isEnabled())

diff --git a/app/src/main/java/org/mozilla/reference/browser/settings/AccountSettingsFragment.kt b/app/src/main/java/org/mozilla/reference/browser/settings/AccountSettingsFragment.kt
@@ -171,6 +171,6 @@ class AccountSettingsFragment : PreferenceFragmentCompat() {
         SyncEngine.History -> pref_key_sync_history
         SyncEngine.Passwords -> pref_key_sync_passwords
         SyncEngine.Tabs -> pref_key_sync_tabs
-        else -> throw IllegalStateException("Accessing unsupported sync engines")
+        else -> error("Accessing unsupported sync engines")
     }
 }
diff --git a/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt b/app/src/main/java/org/mozilla/reference/browser/tabs/synced/SyncedTabsAdapter.kt
@@ -25,7 +25,7 @@ class SyncedTabsAdapter(
         return when (viewType) {
             DeviceViewHolder.LAYOUT_ID -> DeviceViewHolder(itemView)
             TabViewHolder.LAYOUT_ID -> TabViewHolder(itemView)
-            else -> throw IllegalStateException()
+            else -> error("Unable to create ViewHolder")
         }
     }