Bug 1806170 - Align detekt config between Focus and Android Components #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadilek
approved these changes
Dec 16, 2022
gabrielluong
commented
Dec 16, 2022
| AbsentOrWrongFileLicense: | ||
| active: true |
There was a problem hiding this comment.
This will be a notable change because in 1.19.0 this rule changed to expects a template file to match the license. https://detekt.dev/docs/rules/comments#absentorwrongfilelicense
We can address re-enabling this rule and adding more rules as follow up after #292
gabrielluong
force-pushed
the
1806170
branch
from
8397bdc
to
d2b40bb
Compare
gabrielluong
force-pushed
the
1806170
branch
from
a6df401
to
d2b40bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1806170
Pull Request checklist
After merge
GitHub Automation
Used by GitHub Actions.