chore(tests): Make them work #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several issues with these tests preventing them from working. * The parallelism caused port collision despite using a random port * The `run_before` section in tox.ini caused several issues in parallel as it was killing the testing harness for other tests while running * There is a bug in flask-restful which prevents it from correctly parsing args if you do not specify location and are running inside a virtual environment. flask-restful/flask-restful#936 * Moto changed it's testing signature requiring arity of two. * The psycopg2 manually installed version doesn't seem to work correctly in the tests and there are comments saying as much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several issues with these tests preventing them from working.
run_beforesection in tox.ini caused several issues in parallelas it was killing the testing harness for other tests while running
parsing args if you do not specify location and are running inside a
virtual environment. reqparse raises on any non-JSON request with Werkzeug 2.1.0 flask-restful/flask-restful#936
in the tests and there are comments saying as much