Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support worker threads with custom current working directory #131

Conversation

Lakitna
Copy link

@Lakitna Lakitna commented Apr 3, 2020

Closes #130

@Lakitna
Copy link
Author

Lakitna commented Apr 3, 2020

So yeah that was to be expected. CI fails on Node < 12 due to worker threads not existing in those versions.

Cannot find module 'worker_threads'

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #131 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          162       165    +3     
  Branches        34        34           
=========================================
+ Hits           162       165    +3     
Impacted Files Coverage Δ
lib/util/resolveCommand.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76e7bb...6dbad20. Read the comment docs.

@satazor
Copy link
Contributor

satazor commented Apr 4, 2020

See #132

@satazor satazor closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work inside workers threads with custom current working directory
3 participants