CI Fixes #51
CI Fixes #51
Conversation
|
https://github.com/movementlabsxyz/movement/actions/runs/9053736152/job/24872803247 This works. The last thing to try and fix for this PR would be the Monza derivation in a separate file. For some reason that build didn't work. |
|
Until we have Cachix or similar, one workflow will be better because it will share the build context. |
|
@radupopa369 you used cachix before to get fast CI with nix? If I remember correctly. |
|
I'll wait for the workflow to complete before I review! 🚀 |
|
From CI |
|
For whatever reason the DeterminateSystems action doesn't install garbage collect which would help clean our environment. Anyways, just trying to add a few things. I'm going to pause here, so if the lates passes that'll be all for this PR, otherwise, I'll revert to f13c370 |
|
@0xmovses @mzabaluev Pausing here for now: 0134626 |
.github/workflows/checks.yml
Outdated
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 |
flake.nix
Outdated
|
|
||
| shellHook = '' | ||
| #!/bin/bash | ||
| export MONZA_APTOS_PATH=$(nix path-info -r .#monza-aptos | tail -n 1) | ||
| export PATH=$PATH:''${CARGO_HOME:-~/.cargo}/bin | ||
| export PATH=$PATH:''${RUSTUP_HOME:-~/.rustup}/toolchains/$RUSTC_VERSION-x86_64-unknown-linux-gnu/bin/ |
There was a problem hiding this comment.
- rustup is used to install the toolchain, but cannot be invoked in the shell to run the binaries?
- This is Linux-specific, I assume it's OK since it only runs in Nix.
There was a problem hiding this comment.
Let's see what happens if I drop either of these out.
scripts/celestia/celestia-local-appd
Outdated
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash -e | |||
| APP_PATH="./.etc/celestia/${CELESTIA_CHAIN_ID}/.celestia-app" | |||
| NODE_PATH="./.etc/celestia/${CELESTIA_CHAIN_ID}/bridge" | |||
| exec > /dev/null 2>&1 # TODO: drop this line once we have debugged | |||
There was a problem hiding this comment.
Re-enable the output before it's merged?
| done | ||
| echo "Discovered genesis: $GENESIS" | ||
|
|
||
| if [ "${#GENESIS}" -le 4 ]; then |
There was a problem hiding this comment.
The condition looks weird: why does genesis hash need to be at least 4 characters long, rather than just non-empty?
|
|
||
| export CELESTIA_CUSTOM=$CELESTIA_CHAIN_ID:$GENESIS | ||
| echo "$CELESTIA_CUSTOM" | ||
|
|
||
| exec > /dev/null 2>&1 # TODO: drop when we have debugged |
There was a problem hiding this comment.
Remove the temporary hack here as well.
yes @0xmovses used hosted solution from https://www.cachix.org/ |
|
Goodbye broken window... |
check,just m1-da-light-node, just monza-full-node`.