Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Loss Mismatch Issues in BanditPAM #260

Merged
merged 30 commits into from Jul 2, 2023
Merged

Fixed Loss Mismatch Issues in BanditPAM #260

merged 30 commits into from Jul 2, 2023

Conversation

lukeleeai
Copy link
Collaborator

@lukeleeai lukeleeai commented Jun 28, 2023 •
edited

  • Loss issues are resolved in all versions of BanditPAM
  • The clustering results are now identical to scikit-learn's implementation
image image

motiwari and others added 24 commits April 18, 2023 15:09
Fixing linking for M1 Macs local build by ensuring all libraries are …
ca1a711 
…arm64. Does not work with conda right now
Undoing some library_dirs just to test GHA
c79e0ab
Attempting to remove --no-use-pep517
362e712
Trying to install setuptools and wheel
6f068fc
Attempting GHA again
c04a2ce
Set up scaling experiments
5732040
Removed unnecessary files in experiments folder
c757f7d
Merge branch 'main' of github.com:motiwari/BanditPAM into experiments
b27f5c0
Sharing the ScRNA experiment results
405cb34
Added CIFAR
dcda713
Backup for debuggin the loss and sample complexity
cdc4fd7
Loss & Sample Complexity Issue Fixed
6b7f504
Fixed the repro_script.sh bug
bf6e56f
Updated plot_graph.py to skip the error bar for LOSS graphs
f753ecf
Running the exp with 10 seeds
6cdb157
Running the exp with 10 seeds
a125160
Updated the repro script to build the package from the source
378d3fa
cleaned up the code & ran 10 exps for mnist
0c563b3
Formatted the code with black
0a4c7f9
Pulled the main and resolved the conflicts
f883d24
Reset the run_scaling_experiment_with_n to its original settings
ecaf132
Reformatted the code
fe5d9fb
Removed experiments folder
00547a8
Removed experiments folders
92c719b
@height
Copy link

height bot commented Jun 28, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

motiwari
motiwari requested changes Jun 30, 2023
View reviewed changes
data/mnist_change_size.py Outdated Show resolved Hide resolved
data/preprocess_cifar.py Outdated Show resolved Hide resolved
repro_script.py Outdated Show resolved Hide resolved
repro_script.sh Outdated Show resolved Hide resolved
scripts/cache_measurements.py Outdated Show resolved Hide resolved
src/algorithms/banditpam.cpp Outdated Show resolved Hide resolved
src/algorithms/banditpam_orig.cpp Outdated Show resolved Hide resolved
src/algorithms/banditpam_orig.cpp Outdated Show resolved Hide resolved
src/algorithms/banditpam_orig.cpp Outdated Show resolved Hide resolved
src/algorithms/kmedoids_algorithm.cpp Outdated Show resolved Hide resolved
motiwari
motiwari approved these changes Jul 1, 2023
View reviewed changes
Copy link
Owner

@motiwari motiwari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Looks good! @Adarsh321123 can you merge this into v4.0.3

@Adarsh321123 Adarsh321123 changed the base branch from main to v4.0.3_prerelease July 2, 2023 03:22
@Adarsh321123
Copy link
Collaborator

@lukeleeai pls make sure to close any appropriate bugs when this PR is merged!

@Adarsh321123 Adarsh321123 merged commit 53ef393 into v4.0.3_prerelease Jul 2, 2023
@Adarsh321123 Adarsh321123 deleted the fixed_loss branch July 2, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motiwari motiwari motiwari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukeleeai @Adarsh321123 @motiwari