fix: Set NodeJS v14 as the oldest supported engine version #811
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotenv v16.4.3 can't be used with Node 12 because the change introduced in the PR #805 contains an optional chaining operator that is supported by NodeJS starting from v14, thus running it with v12 engine version results in the ```js if (options?.encoding) { ^ SyntaxError: Unexpected token '.' ``` exception. Considering that Node v12 has reached EOL I assume it's better to set v14 as the oldest version constraint.
|
maybe, but it would be nice to still support older versions. many people still run node 12 in production. @thanosd would you like to take a crack at modify that to support node 12? |
|
You beat me to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotenv v16.4.3 can't be used with Node 12 because the change introduced in the PR #805 contains an optional chaining operator that is supported by NodeJS starting from v14, thus running it with v12 engine version results in the
exception.
Considering that Node v12 has reached EOL I assume it's better to set v14 as the oldest version constraint.