Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #416

Merged
merged 3 commits into from Aug 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flowconfig
Expand Up @@ -20,4 +20,4 @@ untyped-import
untyped-type-import

[version]
^0.92.1
^0.105.2
3 changes: 0 additions & 3 deletions .travis.yml
Expand Up @@ -9,14 +9,11 @@ os:
node_js:
- "8"
- "10"
- "11"
- "12"

cache: npm

matrix:
fast_finish: true
allow_failures:
- os: windows

after_success: if [[ "$TRAVIS_OS_NAME" != 'windows' ]]; then npm run flow; fi
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -200,7 +200,7 @@ If you want to override `process.env` you can do something like this:
const fs = require('fs')
const dotenv = require('dotenv')
const envConfig = dotenv.parse(fs.readFileSync('.env.override'))
for (let k in envConfig) {
for (const k in envConfig) {
process.env[k] = envConfig[k]
}
```
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
Expand Up @@ -5,6 +5,7 @@ environment:
matrix:
- nodejs_version: "8"
- nodejs_version: "10"
- nodejs_version: "12"

# Install scripts. (runs after repo cloning)
install:
Expand Down
2 changes: 1 addition & 1 deletion lib/main.js
Expand Up @@ -96,7 +96,7 @@ function config (options /*: ?DotenvConfigOptions */) /*: DotenvConfigOutput */
const parsed = parse(fs.readFileSync(dotenvPath, { encoding }), { debug })

Object.keys(parsed).forEach(function (key) {
if (!process.env.hasOwnProperty(key)) {
if (!Object.prototype.hasOwnProperty.call(process.env, key)) {
process.env[key] = parsed[key]
} else if (debug) {
log(`"${key}" is already defined in \`process.env\` and will not be overwritten`)
Expand Down