Fix removing unbalanced quotes #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes outdated projects and makes future maintaince easier
This was referenced Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in #374, single leading or trailing quotes were being removed. This could cause a problem if your password began or ended with
'or". Now, quotes must be balanced if they are to be removed.Additionally, whitespace will now be preserved within quotes. The Rules section of the README has been updated to clarify quote behavior.
These could be breaking changes so will release v7 after merging. While we're at it, dropping
loadalias since it's only referenced once and is inconsistent with CLI usage (node -r dotenv/config ...). Links to other packages have been simplified to fix outdated links and make future maintainance easier.