Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket notation fix #71

Merged
merged 4 commits into from Mar 21, 2022
Merged

Conversation

devule
Copy link
Contributor

@devule devule commented Mar 20, 2022

Fixed #70

  • Updated regexes to work with default values correctly
  • Added test cases to test fixed problem
  • Fixed npm test script that didn't work because of the pattern
  • Bumped v8.0.3

@@ -18,7 +18,7 @@
"dts-check": "tsc --project tests/types/tsconfig.json",
"lint": "standard",
"pretest": "npm run lint && npm run dts-check",
"test": "lab tests/* --coverage"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused Could not find test file or directory 'tests/*'. problem when running npm test

@motdotla motdotla merged commit 7fe3ef5 into motdotla:master Mar 21, 2022
@motdotla
Copy link
Owner

Great PR. Thank you, and thank you for the contribution. 💛

@motdotla
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bracket notation with default does not work with /
2 participants