Add finalizers to prevent memory leaking #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen some processes leaking memory when using this library.
After looking at this issue
klauspost/compress#264
It seems like it was fixed in kafka-go by using finalizers to ensure that Close was called in the wrapped objects when the GC cleans them up, otherwise the goroutines in compress will leak.
https://github.com/segmentio/kafka-go/blob/master/zstd/zstd.go#L39-L47