documentation/python: make links to literal ellipses as well #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a literal `...` is in a type annotation, it should link to Python documentation like any other builtin type. TODO: right now it's changed to a link that says Ellipsis instead of ..., which isn't desired -- there has to be either some special-casing inside m.sphinx inventory parsing (but that'd have to narrow this patching down to just Python's own inventory, which is rather impossible to detect), or there has to be e.g. an optional argument to make_name_link() that overrides the link title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a literal
...is in a type annotation, it should link to Python documentation like any other builtin type. TODOs:..., which isn't desiredm.sphinxinventory parsing (but that'd have to narrow this patching down to just Python's own inventory, which is rather impossible to detect)make_name_link()that overrides the link title.