Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package testing/fstest is not in GOROOT of golang1.14 #372

Merged
merged 4 commits into from Dec 20, 2021

Conversation

wenxuwan
Copy link
Member

What this PR does:
change github.com/klauspost/compress version to golang1.14 support

refer klauspost/compress#432
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mosn-community-bot mosn-community-bot bot added bug Something isn't working cla:yes size/M labels Dec 19, 2021
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #372 (158acfc) into main (7673018) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   57.93%   57.98%   +0.05%     
==========================================
  Files         106      106              
  Lines        5636     5636              
==========================================
+ Hits         3265     3268       +3     
+ Misses       2035     2033       -2     
+ Partials      336      335       -1     
Impacted Files Coverage Δ
components/rpc/invoker/mosn/channel/xchannel.go 83.87% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7673018...158acfc. Read the comment docs.

Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit 3cf8915 into mosn:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants