Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes mis specified dependency #1919

Merged
merged 11 commits into from Jan 28, 2023
Merged

Fixes mis specified dependency #1919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ae671b4
try list conversion
dakinggg Jan 28, 2023
dd6fe39
revert previous attempt and fix streaming spec
dakinggg Jan 28, 2023
da92728
upgrade isort version
dakinggg Jan 28, 2023
b988918
move pip install to command section so that it can pick up changes to…
dakinggg Jan 28, 2023
12c7feb
add log
dakinggg Jan 28, 2023
f4a7a0f
add log
dakinggg Jan 28, 2023
4e31b90
try removing cache
dakinggg Jan 28, 2023
ee64a8a
revert debugging changes
dakinggg Jan 28, 2023
ee695d5
remov debugging print
dakinggg Jan 28, 2023
aa6fe1a
remove editable install
dakinggg Jan 28, 2023
904778c
move pip install
dakinggg Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/mcp/mcp_pytest.py
View file
Open in desktop
Expand Up @@ -28,7 +28,6 @@
'integration_type': 'git_repo',
'git_repo': 'mosaicml/composer',
'ssh_clone': 'False',
'pip_install': '--user -e .[all]',
}
if args.git_branch is not None and args.git_commit is None:
git_integration['git_branch'] = args.git_branch
Expand All @@ -49,6 +48,8 @@

command += f'''

pip install --user .[all]

export COMMON_ARGS="-v --durations=20 -m '{args.pytest_markers}'"

make test PYTEST='{args.pytest_command}' EXTRA_ARGS="$COMMON_ARGS --codeblocks"
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@ repos:
- repo: https://github.com/pycqa/isort
hooks:
- id: isort
rev: 5.10.1
rev: 5.12.0
# - repo: https://github.com/pycqa/pylint
# hooks:
# - id: pylint
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Expand Up @@ -180,7 +180,7 @@ def package_files(prefix: str, directory: str, extension: str):
]

extra_deps['streaming'] = [
'mosaicml-streaming<0.3.*',
'mosaicml-streaming<0.3',
'boto3>=1.21.45,<2',
'paramiko>=2.11.0,<3',
]
Expand Down