Fix default scroll lock state

morassman · Mar 27, 2021 · f1f56f3 · f1f56f3
1 parent 3e677e1
commit f1f56f3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/lib/views/main-view.js b/lib/views/main-view.js
@@ -100,6 +100,10 @@ export default class MainView extends View {
   }
 
   showProcessOutput(processController) {
+    if (!processController.config.outputToPanel()) {
+      return
+    }
+
     let tab = this.refs.tabsView.getConfigTab(processController.configController)
 
     if (!tab) {
@@ -152,6 +156,10 @@ export default class MainView extends View {
   processControllerRemoved(processController) {
     const tab = this.refs.tabsView.getConfigTab(processController.configController)
 
+    if (!tab) {
+      return
+    }
+
     const nextProcessController = processController.configController.getFirstProcessController();
 
     // If there are no more left then remove the tab.

diff --git a/lib/views/process-output-view.js b/lib/views/process-output-view.js
@@ -23,8 +23,6 @@ export default class ProcessOutputView extends View {
     this.lineIndex = 0;
     this.patterns = this.processController.configController.patterns;
 
-    // this.addProcessDetails();
-    this.setScrollLockEnabled(this.processController.config.scrollLockEnabled);
     this.initialize()
   }
 
@@ -54,7 +52,13 @@ export default class ProcessOutputView extends View {
     super.initialize()
 
     this.addTooltips()
-    this.refreshScrollLockButton()
+
+    if (this.processController.config.scrollLockEnabled) {
+      this.setScrollLockEnabled(true)
+    } else {
+      this.refreshScrollLockButton()
+    }
+
     this.processController.addProcessCallback(this)
     this.outputChanged()
   }
@@ -134,11 +138,11 @@ export default class ProcessOutputView extends View {
     }
 
     this.scrollLocked = enabled;
-    return this.refreshScrollLockButton();
+    this.refreshScrollLockButton();
   }
 
   showListView() {
-    return this.main.showListView();
+    this.main.showListView();
   }
 
   runButtonPressed() {