New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.10 #2042
Support Python 3.10 #2042
Conversation
I used this as a guide: 06be362 |
I'm not sure why this would have resulted in a decrease in code coverage. I don't see that as a reason to block merging this PR. |
Perhaps it's also time to remove Python 3.7. Debian stable has 3.9, Ubuntu LTS has 3.8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this :-)
I'm open to dropping 3.7 support, but I think we can leave it for another PR, and maybe only do it when we want to use some feature that requires 3.8.
44c9029
to
5f8624e
Compare
Regarding dropping Python 3.7 support, the usual way I see this handled is to make one last release that supports the old version, then immediately drop support after the release. There's a few bugfixes waiting on the |
5f8624e
to
a73fe13
Compare
I'm having trouble running flake8 on my dev environment following this change.
|
Argh, stung yet again by the uselesness of |
Maybe I should test out converting Mopidy to Poetry? I think the main thing to figure out is the best workflow for multiple extensions in the same venv. |
I would love to see the Mopidy ecosystem move towards Poetry 👍 I normally do the following:
I think if you wanted to install extensions and/or core inside the same virtualenv, you'd need to pick the "main" package you're working on, and make sure to run |
I agree with @djmattyg007. Unless keeping back-compatibility unnecessarily complicates things, I wouldn't drop support for Debian's |
I don't think we should be waiting much longer to drop 3.7 support. Python 3.7 was released over 3.5 years ago, and is going to start holding us back. |
Oops, this was meant to say |
If poetry solves the shambolic dependency upgrade mess in a virtualenv I'm all for it. |
No description provided.