Add mongoid 8.0.x support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Jan 10, 2023
|
Looks good. Iterate to green for all versions. IMO the ruby version matrix is huge. I would reduce it like in mongoid/mongoid-grid_fs#81. |
Let me check that PR and update accordingly. |
|
@dblock I have updated the PR and Github Actions are working as expected. https://github.com/randikabanura/mongoid-locker/actions/runs/3880159948 |
dblock
requested changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongoid has released the mongoid 8 version. hence this PR adds support for mongoid 8.0.x versions for the gem.
Tests are passing without an issue for new mongoid version.
This closes #94