Restore a working CI with GHA #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, in mongoid/mongoid-grid_fs#81 I have a much more sane implementation for a test matrix that doesn't explode. For another PR if you feel like it. |
dblock
reviewed
Jan 6, 2023
|
LGTM! |
rsosag
added a commit
to rsosag/mongoid-locker
that referenced
this pull request
Jan 9, 2023
Restore a working CI with GHA (mongoid#96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Restoring the CI with GHA before adding support to mongoid v8. For more context see the issue #94
Changes
TODO
The experimental cases of the matrix still fail, the reason seems to be that the version 7 of
mongoid/i18ndoesn't support ruby 3 馃憞馃徏https://github.com/rsosag/mongoid-locker/actions/runs/3834210130