Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2406 add Rewrap prose test #1287

Merged
merged 1 commit into from Aug 1, 2022
Merged

DRIVERS-2406 add Rewrap prose test #1287

merged 1 commit into from Aug 1, 2022

Conversation

kevinAlbs
Copy link
Contributor

Summary

  • Add a prose test to test RewrapManyDataKey.

Background & Motivation

This is an integration regression test for MONGOCRYPT-464.

Please complete the following before merging:

  • Bump spec version and last modified date. N/A
  • Update changelog. N/A
  • Make sure there are generated JSON files from the YAML test files. N/A
  • Test changes in at least one language driver. Tested in Go
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@kevinAlbs kevinAlbs changed the title DRIVERS-2403 add Rewrap prose test DRIVERS-2406 add Rewrap prose test Jul 30, 2022
@kevinAlbs kevinAlbs marked this pull request as ready for review July 30, 2022 19:55
@kevinAlbs kevinAlbs requested a review from a team as a code owner July 30, 2022 19:55
@kevinAlbs kevinAlbs requested review from comandeo, eramongodb and DmitryLukyanov and removed request for a team and comandeo July 30, 2022 19:55
DmitryLukyanov
DmitryLukyanov approved these changes Jul 31, 2022
View reviewed changes
Copy link

@DmitryLukyanov DmitryLukyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs merged commit 0726016 into mongodb:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo comandeo comandeo approved these changes

@DmitryLukyanov DmitryLukyanov DmitryLukyanov approved these changes

@eramongodb eramongodb eramongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinAlbs @comandeo @DmitryLukyanov @eramongodb