Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1284

Closed
wants to merge 3 commits into from
Closed

Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 #1284

wants to merge 3 commits into from

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Jul 29, 2022 •
edited

Summary

  • Add documentation requirement to alert users not to use RewrapManyDataKey with libmongocrypt < 1.5.2.
  • Recommend drivers return an error if RewrapManyDataKey is called and libmongocrypt version is < 1.5.2.

Background & Motivation

Returning an error is intended to limit risk of users hitting the bug of MONGOCRYPT-464.

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files. N/A
  • Test changes in at least one language driver. Tested in Go
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@kevinAlbs kevinAlbs changed the title DRIVERS-2403 add Rewrap prose test DRIVERS-2403 add RewrapManyDataKey prose test Jul 30, 2022
@kevinAlbs kevinAlbs changed the title DRIVERS-2403 add RewrapManyDataKey prose test DRIVERS-2406 add RewrapManyDataKey prose test Jul 30, 2022
@kevinAlbs kevinAlbs changed the title DRIVERS-2406 add RewrapManyDataKey prose test Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 Jul 30, 2022
@kevinAlbs kevinAlbs changed the title Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 DRIVERS-2408 Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 Jul 30, 2022
@kevinAlbs kevinAlbs changed the title DRIVERS-2408 Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 Error if RewrapManyDataKey is called with libmongocrypt < 1.5.2 Jul 30, 2022
@kevinAlbs
Copy link
Contributor Author

Closing. Superseded by other PRs.

@kevinAlbs kevinAlbs closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kevinAlbs