Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRIVERS-2386 Improve reliability of SDAM heartbeat error spec tests. #1272

Merged
merged 2 commits into from
Jul 13, 2022
Merged

DRIVERS-2386 Improve reliability of SDAM heartbeat error spec tests. #1272

merged 2 commits into from
Jul 13, 2022

Conversation

matthewdale
Copy link
Contributor

@matthewdale matthewdale commented Jul 8, 2022 •
edited

DRIVERS-2386

Please complete the following before merging:

  • Bump spec version and last modified date.
  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded clusters, and serverless).

@matthewdale matthewdale requested a review from a team as a code owner July 8, 2022 23:31
@matthewdale matthewdale requested review from nbbeeken and removed request for a team July 8, 2022 23:31
This was referenced Jul 11, 2022
Merged
Closed
@matthewdale
Copy link
Contributor Author

Tested in the Go driver in mongodb/mongo-go-driver#994 and mongodb/mongo-go-driver#1018.

@nbbeeken nbbeeken mentioned this pull request Jul 12, 2022
Merged
5 tasks
nbbeeken
nbbeeken requested changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests pass for Node.js EVG RUN
Just some clean up to the yaml, ty!

source/server-discovery-and-monitoring/tests/integration/hello-command-error.yml Outdated Show resolved Hide resolved
source/server-discovery-and-monitoring/tests/integration/hello-timeout.yml Outdated Show resolved Hide resolved
@matthewdale matthewdale force-pushed the drivers2386-fix-heartbeat-err-test branch from 52ce6ad to 3689ecf Compare July 13, 2022 17:00
ShaneHarvey
ShaneHarvey approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, passes in Python too: mongodb/mongo-python-driver#1005

@matthewdale matthewdale merged commit 98e20da into mongodb:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewdale @ShaneHarvey @nbbeeken