fix(NODE-6171): RTT set to zero when serverMonitoringMode=stream #4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
May 15, 2024
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Outdated
Show resolved
Hide resolved
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Outdated
Show resolved
Hide resolved
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Outdated
Show resolved
Hide resolved
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
reviewed
May 15, 2024
test/integration/server-discovery-and-monitoring/server_discover_and_monitoring.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
approved these changes
May 15, 2024
W-A-James
changed the title
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
NODE-6171
Release Highlight
Server Selection performance regression due to incorrect RTT measurement
Starting in version 6.6.0, when using the
streamserver monitoring mode, heartbeats were incorrectly timed as having a duration of 0, leading to server selection viewing each server as equally desirable for selection.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript